[BC-Breaking] Default to native complex type when returning raw spect… #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
force-pushed
the
default-native-complex
branch
from
a20b9fd
to
aa14590
Compare
…rogram Part of pytorch#1337 . - This code changes the return type of spectrogram to be native complex dtype, when (and only when) returning raw (complex-valued) spectrogram. - Change `return_complex=False` to `return_complex=True` in spectrogram ops. - `return_complex` is only effective when `power` is `None`. It is ignored for cases where `power` is not `None`. Because the returned Tensor is power spectrogram, which is real-valued Tensors.
mthrok
force-pushed
the
default-native-complex
branch
from
aa14590
to
57c7f7b
Compare
21 tasks
anjali411
approved these changes
Jun 4, 2021
|
maybe we should create a bc-breaking label for torchaudio? Worth preemptively adding a bc-breaking note that would go in the release notes.
should this go in docs as a note? |
Yeah, we can do that. Currently we track it with
It kind of does, but let me update. audio/torchaudio/functional/functional.py Line 79 in f2a4aac |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
* Update build.sh Picks up 1.9 build from test. * Update build.sh * Update lite interpreter tutorial to beta (pytorch#1549) * Update lite interpreter tutorial to beta * Update lite interpreter to beta * update model export script * address comment and update documentation * add custome build in first paragraph * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Update prototype_source/lite_interpreter.rst Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * replace file name * update ios part Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> * Revert "Update lite interpreter tutorial to beta (pytorch#1549)" (pytorch#1569) This reverts commit a702ca0fafe9d4a1ee0c1e4331de66245ceb3103. * Update build.sh * Update build.sh * updated pipeline tutorial (pytorch#1562) * reduce (pytorch#1546) * Update seq2seq_translation_tutorial.py (pytorch#1532) Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> * added CPU optimization guide part into tuning_guide (pytorch#1512) * added CPU optimization guide part into tuning_guide * changed non-python command to python comments in CPU specific optimization section * Update tuning_guide.py Changed comment of bash commands to double quote. * Update tuning_guide.py Co-authored-by: Brian Johnson <brianjo@fb.com> * Typo fix (pytorch#1538) Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> * Typo fix in text sentiment tutorial (pytorch#1543) Trivial typo fix in docs * Update dcgan_faces_tutorial.py (pytorch#1550) Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> * updated pipeline tutorial Co-authored-by: define_liuyi <793753866@qq.com> Co-authored-by: dhayeah <57786651+dhayeah@users.noreply.github.com> Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> Co-authored-by: Jing Xu <jing.xu@intel.com> Co-authored-by: Brian Johnson <brianjo@fb.com> Co-authored-by: Andrew C. Freeman <andrew.freeman@cawb.com> Co-authored-by: Davide Fiocco <davidefiocco@users.noreply.github.com> Co-authored-by: universuen <52519513+universuen@users.noreply.github.com> * Update audio manipulation tutorial (pytorch#1566) * add resampling tutorial * update benchmarking and sectioning * remove np import * Update torchaudio tutorial * update resample dtype initialization Co-authored-by: moto <855818+mthrok@users.noreply.github.com> * updated text sentiment tutorial (pytorch#1563) * updated transformer tutorial (pytorch#1565) * Update numeric_suite_tutorial.py s/Logger=/logger_cls=/ * Update profiler recipe doc (1.9) (pytorch#1528) Summary: Update the profiler recipe to use the new API and features Test Plan: make html-noplot Co-authored-by: Brian Johnson <brianjo@fb.com> * Update build.sh Co-authored-by: cccclai <chenlai@fb.com> Co-authored-by: Raziel <129535+raziel@users.noreply.github.com> Co-authored-by: parmeet <parmeetbhatia@fb.com> Co-authored-by: define_liuyi <793753866@qq.com> Co-authored-by: dhayeah <57786651+dhayeah@users.noreply.github.com> Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com> Co-authored-by: Jing Xu <jing.xu@intel.com> Co-authored-by: Andrew C. Freeman <andrew.freeman@cawb.com> Co-authored-by: Davide Fiocco <davidefiocco@users.noreply.github.com> Co-authored-by: universuen <52519513+universuen@users.noreply.github.com> Co-authored-by: Caroline Chen <carolinechen@fb.com> Co-authored-by: moto <855818+mthrok@users.noreply.github.com> Co-authored-by: Nikita Shulga <nshulga@fb.com> Co-authored-by: ilia-cher <30845429+ilia-cher@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rogram
As planed in #1337
when (and only when) returning raw (complex-valued) spectrogram.
return_complex=Falsetoreturn_complex=Truein spectrogram ops.return_complexis only effective whenpowerisNone. It is ignored forcases where
poweris notNone. Because the returned Tensor is power spectrogram,which is real-valued Tensors.