-
Notifications
You must be signed in to change notification settings - Fork 732
Closed
Description
Address #1510
In 0.9.0 we are deprecating the lazy behavior of MelScale because it can make an invalid TorchScript object and it does not align with the design of torchaudio. Now in master branch, we can remove the implementation.
See CONTRIBUTING.md for setting up the development environment.
Steps
- Replace
n_stft: Optional[int] = Nonewithn_stft: int = 201. - Remove the branches for
n_stft = None - Remove
__prepare_script__method - Remove the case
numel() == 0 - Remove test
Tests
Run test cd test && pytest torchaudio_unittest.transforms -vk MelScale and make changes to failures.