Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call torch.stft directly #531

Merged
merged 3 commits into from Apr 14, 2020
Merged

Call torch.stft directly #531

merged 3 commits into from Apr 14, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 10, 2020

Found the note

# TODO: remove this once https://github.com/pytorch/pytorch/issues/21478 gets solved

And the issue is resolved and we should not need to wrap torch.stft anymore.

@mthrok mthrok requested a review from vincentqb April 10, 2020 15:27
vincentqb
vincentqb suggested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are failing, see here.

@mthrok
Copy link
Collaborator Author

mthrok commented Apr 13, 2020

Interesting! It does not fail on my environment 🤔

@vincentqb
Copy link
Contributor

Interesting! It does not fail on my environment 🤔

The fix pytorch/pytorch#33504 isn't part of pytorch 1.4.0 on which the torchaudio test environment depends, see .circleci/config.yaml.in.

@vincentqb
Copy link
Contributor

vincentqb commented Apr 13, 2020 •
edited

We'll merge this PR once Pytorch 1.5.0 has landed. Can you update the title to reflect that?

@mthrok
Copy link
Collaborator Author

mthrok commented Apr 13, 2020

Actually, that's not where test environment is defined. it's in https://github.com/pytorch/audio/blob/master/requirements.txt#L1 via https://github.com/pytorch/audio/blob/master/build_tools/travis/install.sh#L51 via https://github.com/pytorch/audio/blob/master/.travis.yml

@vincentqb
Copy link
Contributor

Yes, torchaudio master should depend on pytorch master; and the latest torchaudio release should depend on the latest pytorch release. Do you want to a PR to make torchaudio master depend on pytorch nightly?

@mthrok mthrok mentioned this pull request Apr 13, 2020
Merged
vincentqb
vincentqb approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit 6304db7 into pytorch:master Apr 14, 2020
@mthrok mthrok deleted the remove-internal-sftf branch April 14, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb