[JIT] fix resolving of functions in torch/functional. fix compilation of torch.stft #33504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
eellison
changed the title
facebook-github-bot
added
the
oncall: jit
[ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Feb 19, 2020
ghstack-source-id: ec658b69fab9feab4b836ad76586c869e441aee2 Pull Request resolved: #33504
eellison
changed the title
eellison
changed the title
💊 CircleCI build failures summary and remediationsAs of commit 442016a: Commit 442016a was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 31 times. |
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fix for #21478 [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Feb 20, 2020
ghstack-source-id: fe824a5a6e1ff7b3f980ddadfa152dcd5e77a427 Pull Request resolved: #33504
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fix for #21478 [ghstack-poisoned]
driazati
approved these changes
Feb 20, 2020
torch/jit/_builtins.py
Outdated
| @@ -83,8 +83,25 @@ | |||
| (torch.nn.init._no_grad_zero_, "aten::_no_grad_zero_"), | |||
| (torch._C._get_tracing_state, "aten::_get_tracing_state"), | |||
| (warnings.warn, "aten::warn"), | |||
| (torch._C._VariableFunctions.stft, "aten::stft") | |||
There was a problem hiding this comment.
if you do the above you shouldn't need this here, instances in nn/functional.py resolve to their aten:: equivalent already
pytorch/torch/nn/functional.py
Lines 805 to 806 in cfb4862
There was a problem hiding this comment.
For some reason I had to add _VF.stft here, not sure why. But I moved _VF so that i can just use _VF.stft inline.
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 [ghstack-poisoned]
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Feb 20, 2020
ghstack-source-id: 23bd174a965c5c38e9cc9d18cc212c9872e8cba3 Pull Request resolved: #33504
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
eellison
pushed a commit
that referenced
this pull request
Feb 24, 2020
ghstack-source-id: bfc3f3eb0c57b9d6f894531f5c927caf01eb7558 Pull Request resolved: #33504
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
This was referenced Feb 24, 2020
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
added 3 commits
February 26, 2020 10:34
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
…compilation of torch.stft" Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Differential Revision: [D20014591](https://our.internmc.facebook.com/intern/diff/D20014591) [ghstack-poisoned]
hczhu
pushed a commit
that referenced
this pull request
Feb 28, 2020
… of torch.stft (#33504) Summary: Pull Request resolved: #33504 Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes #21478 Test Plan: Imported from OSS Differential Revision: D20014591 Pulled By: eellison fbshipit-source-id: bb362f1b5479adbb890e72a54111ef716679d127
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
… of torch.stft (pytorch#33504) Summary: Pull Request resolved: pytorch#33504 Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start. Fixes pytorch#21478 Test Plan: Imported from OSS Differential Revision: D20014591 Pulled By: eellison fbshipit-source-id: bb362f1b5479adbb890e72a54111ef716679d127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix resolution fo functions that are bound onto torch in torch/functional.py. This does not fix compilation of all of those functions, those will be done in follow ups. Does torch.stft as a start.
Fixes #21478
Differential Revision: D20014591