Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test module name descriptive #532

Merged
merged 2 commits into from Apr 13, 2020
Merged

Make test module name descriptive #532

merged 2 commits into from Apr 13, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 10, 2020

test/test_io.py better describes what it does than test/test.py. I am open to alternative too.

@mthrok mthrok requested a review from vincentqb April 10, 2020 15:28
vincentqb
vincentqb approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, git blame is still fine.

@vincentqb vincentqb merged commit d45699f into pytorch:master Apr 13, 2020
@mthrok mthrok deleted the refactor-test branch April 13, 2020 19:33
@mthrok mthrok mentioned this pull request Apr 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb