Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lfilter test to test_functional #539

Merged
merged 1 commit into from Apr 14, 2020
Merged

Move lfilter test to test_functional #539

merged 1 commit into from Apr 14, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 13, 2020

Now with #532 landed, lfilter tests (which has nothing to do with SoX, unlike the rest of the tests in the same module) better belongs to test_functional rather than test_sox_compatibility.

@mthrok mthrok requested a review from vincentqb April 13, 2020 21:43
vincentqb
vincentqb approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green. LGTM.

@vincentqb vincentqb merged commit af88b92 into pytorch:master Apr 14, 2020
@mthrok mthrok deleted the refactor-test-2 branch April 14, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb