Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated lfilter tests #541

Merged
merged 1 commit into from Apr 14, 2020
Merged

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Apr 14, 2020

This lfilter tests were moved to test_torchscript_consistency.py in #507 and GPU tests were added in #528.
We can safely remove this tests from test_functional_filtering.py.
You can see the moved test here.

This lfilter tests were moved to `test_torchscript_consistency.py` in pytorch#507 and GPU tests were added in pytorch#528.
We can safely remove this tests from `test_functional_filtering.py`.
@mthrok mthrok requested a review from vincentqb April 14, 2020 14:47
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentqb vincentqb merged commit 0fa0759 into pytorch:master Apr 14, 2020
@mthrok mthrok deleted the refactor-test-3 branch April 14, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants