New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak CCI config #603
Tweak CCI config #603
Conversation
The cache is for conda install packages, right? |
Should the name of the file be changed as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to keep the config files in sync between domains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I meant to say: tests are failling :/
Yes
The thing is, I do not know what this script is for and I think it's obsolete. If we care as much I suggest we delete it.
I don't think that's possible. Torchtext has specific caching which does not apply to other domains.
Weird, rebuilding test image and will retry. |
How about we don't modify it as part of this PR, and we simply delete it in the next? :) If we don't see it used anywhere, the risk is low. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix typos in TensorBoard tutorial
Importing the CCI tweak I found useful while working on pytorch/text#748 pytorch/text#744
rename utility directorytest
->utility
--durations 20