-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CCI cache for test data #748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Dramatic improve for |
|
|
|
cpuhrsch
reviewed
May 1, 2020
mthrok
changed the title
[TEST] Add CCI cache for .vector_cache directory
Add CCI cache for .vector_cache directory
May 1, 2020
mthrok
changed the title
Add CCI cache for .vector_cache directory
Add CCI cache for test data
May 1, 2020
Once this lands we'll need to think of new tests to check that the downloads work. |
cpuhrsch
reviewed
May 1, 2020
- run: | ||
name: Generate cache key | ||
# This will refresh cache on Sundays, nightly build should refresh the cache. | ||
command: echo "$(date +"%Y-%U")" > .circleci-weekly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use this as an opportunity to verify that the download functions continue to download the same files.
cpuhrsch
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching mechanism for Circle CI unit tests.
.vector_caches
and.data
directories are cached.@slow
decorators (implementation and usage) are removed.If one needs to refresh cache manually, update version string in cache key.
such as
data-v1-{{ checksum ".circleci-weekly" }}
->data-v2-...
conda
environment cache.