New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows binary jobs #642
Conversation
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 21 21
Lines 2223 2223
=======================================
Hits 1975 1975
Misses 248 248 Continue to review full report at Codecov.
|
The wheels generated on Windows are noarch. I don't know whether it will break the search process for the wheel packages on Linux/MacOS. |
@seemethere Could you advise? |
@mthrok I tried to make the wheel package specific both on python version and platform. But I guess it is okay without this change. I quoted the related description from PEP-425.
|
Thank you for the link. So based on my understanding of PEP-425, and looking at the job logs, the binaries built are the following. The Windows wheel binaries have I think it's safe to merge this PR. If this does interfere with binaries for Linux or macOS, then we can tell with the nightly smoke test job tomorrow morning. Side note: Is 94994ec sufficient to add ABI for Windows? We plan to revisit and add C++ implementations like #580, #290 which might be able to build on Windows. In that case, we will need to add proper ABI. (though since (from the last line of Uploading artifacts job log)
|
* Add windows binary jobs * Make wheel package platform-specific and python-version-specific
No description provided.