Clean up common_utils #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
- Coverage 89.10% 89.08% -0.03%
==========================================
Files 22 22
Lines 2341 2336 -5
==========================================
- Hits 2086 2081 -5
Misses 255 255
Continue to review full report at Codecov.
|
mthrok
force-pushed
the
cleanup-common-utils
branch
5 times, most recently
from
2a4a33b
to
6c8b1a5
Compare
mthrok
force-pushed
the
cleanup-common-utils
branch
from
6c8b1a5
to
39bd543
Compare
vincentqb
approved these changes
Jun 4, 2020
| @@ -1,17 +1,11 @@ | |||
| import importlib.util | |||
|
|
|||
|
|
|||
| def _check_module_exists(name: str) -> bool: | |||
| def _check_module_exists(*modules: str) -> bool: | |||
There was a problem hiding this comment.
nit: the typing for this works? If so, I like it :)
| @@ -115,12 +117,8 @@ def test_amplitude_to_DB(self): | |||
| ]) | |||
| @pytest.mark.parametrize('rate', [0.5, 1.01, 1.3]) | |||
| @pytest.mark.parametrize('hop_length', [256]) | |||
| @unittest.skipIf(not LIBROSA_AVAILABLE, "Librosa not available") | |||
There was a problem hiding this comment.
Thanks for addressing comment
|
thanks! |
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Re-add model parallel tutorial
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Removes compatibility code forRemove PY<3.4 code from common_utils #691Python < 3.4fromtorchaudio.common_utils.IMPORT_KALDI_IOglobal variable tokaldi_iomodule because it's only used there and does not seem to be useful elsewhere.IMPORT_LIBROSAglobal variable to test because it's only used intest_librosa_compatibility.py.IMPORT_NUMPYandIMPORT_SCIPYas they are redundant. (Iflibrosais availablenumpyandscipyshould be available too, else installation is broken and that's nottorchaudio's responsibility to watch out such case.)