Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PY<3.4 code from common_utils #691

Merged
merged 1 commit into from Jun 4, 2020
Merged

Remove PY<3.4 code from common_utils #691

merged 1 commit into from Jun 4, 2020

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Jun 4, 2020

No description provided.

@mthrok mthrok marked this pull request as draft June 4, 2020 15:51
@mthrok mthrok marked this pull request as ready for review June 4, 2020 16:00
@mthrok mthrok requested a review from vincentqb June 4, 2020 16:00
@codecov
Copy link

codecov bot commented Jun 4, 2020 •
edited

Codecov Report

Merging #691 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   88.79%   89.10%   +0.31%     
==========================================
  Files          22       22              
  Lines        2356     2341      -15     
==========================================
- Hits         2092     2086       -6     
+ Misses        264      255       -9
Impacted Files Coverage Δ
torchaudio/common_utils.py 100.00% <100.00%> (+39.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4284de...9cb12bb. Read the comment docs.

@vincentqb
Copy link
Contributor

#477

vincentqb
vincentqb approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it

@mthrok mthrok merged commit b56a27b into pytorch:master Jun 4, 2020
@mthrok
Copy link
Collaborator Author

mthrok commented Jun 4, 2020

thanks!

@mthrok mthrok deleted the common-util-py2 branch June 4, 2020 17:30
@mthrok mthrok mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentqb vincentqb vincentqb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mthrok @vincentqb