Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaldi compliance files cleanup for spec,fbank,mfcc #703

Merged
merged 2 commits into from Jun 8, 2020

Conversation

bhargavkathivarapu
Copy link
Contributor

This PR Relates to kaldi migration (#597 ) cleanup for mfcc( #681 ) , fbank ( #672 ) , spectrogram (#687)

  • Remove .ark files for mfcc,fbank,spec
  • Remove compliance test for mfcc,fbank,spec in test/test_compliance_kaldi.py
  • This also include removal for 3 failing mfcc GPU tests as per ( Migrate kaldi mfcc #681 )

Signed-off-by: Bhargav Kathivarapu <bhargavkathivarapu31@gmail.com>
Signed-off-by: Bhargav Kathivarapu <bhargavkathivarapu31@gmail.com>
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   89.29%   89.29%           
=======================================
  Files          23       23           
  Lines        2335     2335           
=======================================
  Hits         2085     2085           
  Misses        250      250           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ed19a...53cf7f6. Read the comment docs.

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks!

@mthrok mthrok merged commit 0bd9148 into pytorch:master Jun 8, 2020
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants