-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Kaldi tests #597
Comments
We should also have CI catch errors like #613 on gpu |
@vincentqb , For below kaldi compliance tests, Do we need to write a compatibility test cases for each saved files configurations(function args in filenames) in test/kaldi or one test configuration is enough for each
For remaining tests , they are not dependent on the saved kaldi files in test/kaldi ( though they are referencing a external .wav file , they are not comparing its contents ) , we can directly move them to compatibility without much changes |
The tests should cover the same cases. Is that what you meant? |
@vincentqb yes , Like for test_fbank there are 97 kaldi files , each file name is variation of kaldi fbank function arguments
So we need to keep all these 97 configurations( function argument variations) in a text file , |
Yes, that is what I mean. We need to maintain the same coverage. |
[new] Update Deploy Seq2Seq Tutorial with New TorchScript API
We used to test kaldi against a saved kaldi output here, but we now have an infrastructure to run kaldi in our test environment here.
We would like to migrate the tests from "saved kaldi" to "live kaldi".
test_spectrogram
test_fbank
test_mfcc
test_mfcc_empty
test_resample_waveform
test_resample_waveform_upsample_size
test_resample_waveform_downsample_size
test_resample_waveform_identity_size
test_resample_waveform_downsample_accuracy
test_resample_waveform_upsample_accuracy
test_resample_waveform_multi_channel
The text was updated successfully, but these errors were encountered: