Pin rapidfuzz dep to 2.15.1 #1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
ngimel
approved these changes
Apr 17, 2023
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
janeyx99
approved these changes
Apr 17, 2023
xuzhao9
approved these changes
Apr 17, 2023
kit1980
approved these changes
Apr 17, 2023
weiwangmeta
pushed a commit
that referenced
this pull request
Apr 18, 2023
Summary:
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
Pull Request resolved: #1555
Reviewed By: xuzhao9
Differential Revision: D45067492
Pulled By: malfet
fbshipit-source-id: 6d4dc33f4f75f8c26e2e33648e8b6db2bcfe285c
weiwangmeta
pushed a commit
that referenced
this pull request
Apr 18, 2023
Summary:
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
Pull Request resolved: #1555
Reviewed By: xuzhao9
Differential Revision: D45067492
Pulled By: malfet
fbshipit-source-id: 6d4dc33f4f75f8c26e2e33648e8b6db2bcfe285c
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 18, 2023
To fix `doctr` installation for torchbench tests, see pytorch/benchmark#1555 Pull Request resolved: #99386 Approved by: https://github.com/kit1980, https://github.com/weiwangmeta
xuzhao9
pushed a commit
that referenced
this pull request
Apr 18, 2023
Summary:
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
Pull Request resolved: #1555
Reviewed By: xuzhao9
Differential Revision: D45067492
Pulled By: malfet
fbshipit-source-id: 6d4dc33f4f75f8c26e2e33648e8b6db2bcfe285c
Co-authored-by: Nikita Shulga <nshulga@meta.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
Summary: Update the version of `doctr` to include the fix in mindee/doctr#1342 for BF16 mode. Remove the change of `rapidfuzz==2.15.1` in `requirements.txt` (#1555) since the version has been set in the model repo in the updated version (mindee/doctr#1176). Pull Request resolved: #1979 Reviewed By: aaronenyeshi Differential Revision: D50242780 Pulled By: xuzhao9 fbshipit-source-id: d8ed9164d463a1217114408106b2c745431bd159
gairgeio
added a commit
to gairgeio/benchmark
that referenced
this pull request
Aug 2, 2024
Summary:
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
Pull Request resolved: pytorch/benchmark#1555
Reviewed By: xuzhao9
Differential Revision: D45067492
Pulled By: malfet
fbshipit-source-id: 6d4dc33f4f75f8c26e2e33648e8b6db2bcfe285c
bestappsandcodereviews7
added a commit
to bestappsandcodereviews7/benchmark
that referenced
this pull request
Aug 16, 2024
Summary:
As repo is incompatible with `rapidfuzz-3.0.0`:
```python
>>> import doctr
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/__init__.py", line 1, in <module>
from . import datasets, io, models, transforms, utils
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/__init__.py", line 4, in <module>
from .recognition import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/__init__.py", line 5, in <module>
from .zoo import *
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/zoo.py", line 12, in <module>
from .predictor import RecognitionPredictor
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/__init__.py", line 6, in <module>
from .pytorch import * # type: ignore[misc]
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/pytorch.py", line 14, in <module>
from ._utils import remap_preds, split_crops
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/predictor/_utils.py", line 10, in <module>
from ..utils import merge_multi_strings
File "/home/nshulga/miniconda3/envs/py310/lib/python3.10/site-packages/doctr/models/recognition/utils.py", line 8, in <module>
from rapidfuzz.string_metric import levenshtein
ModuleNotFoundError: No module named 'rapidfuzz.string_metric'
```
Propose fix upstream in mindee/doctr#1176
Pull Request resolved: pytorch/benchmark#1555
Reviewed By: xuzhao9
Differential Revision: D45067492
Pulled By: malfet
fbshipit-source-id: 6d4dc33f4f75f8c26e2e33648e8b6db2bcfe285c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As repo is incompatible with
rapidfuzz-3.0.0:Propose fix upstream in mindee/doctr#1176