Stop some warnings in unit tests #1992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esantorella
requested review from
Balandat,
sdaulton,
saitcakmak and
SebastianAment
facebook-github-bot
added
the
CLA Signed
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1992 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 178 178
Lines 15719 15721 +2
=======================================
+ Hits 15718 15720 +2
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary: ## Motivation Warning output from unit tests sometimes indicates a serious problem and sometimes merely clutters the output so we can't notice the serious problems. These warnings are the latter: * InputDataWarning: Input data is not contained to the unit cube. Please consider min-max scaling the input data (occurred 194 times, now 0) * BadInitialCandidatesWarning: Unable to find non-zero acquisition function values - initial conditions are being selected randomly. (occurred 40 times, now 0) * The first positional argument of samplers, `num_samples`, has been deprecated and replaced with `sample_shape`, which expects a `torch.Size` object.' (occurred 35 times, now 0) ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: pytorch#1992 Test Plan: Units ## Related PRs pytorch#1792, pytorch#1539 Reviewed By: saitcakmak Differential Revision: D48530764 Pulled By: esantorella fbshipit-source-id: 0d1dcd9d0ea6732f0bb639e0ba00ba93103b4ef4
|
This pull request was exported from Phabricator. Differential Revision: D48530764 |
esantorella
force-pushed
the
unit_test_warnings
branch
from
7bb3f22
to
2d65431
Compare
|
@esantorella merged this pull request in 4cc5ed5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Warning output from unit tests sometimes indicates a serious problem and sometimes merely clutters the output so we can't notice the serious problems. These warnings are the latter:
num_samples, has been deprecated and replaced withsample_shape, which expects atorch.Sizeobject.' (occurred 35 times, now 0)Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Units
Related PRs
#1792, #1539