Reap deprecated mvn argument to GPyTorchPosterior
#2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55092855 |
Summary: X-link: facebookexternal/botorch_fb#17 The `base_samples` argument to GPyTorchPosterior.rsample was deprecated in BoTorch 8.0.0 - reaped the deprecated code - removed the corresponding unit tests - Removed `base_samples` argument from `MockPosterior.rsample` used for testing, since the base Posterior class also does not permit `base_samples` in `rsample`. Moved an exception in `MockPosterior` so that invalid `base_samples` will still be checked. - fixed a docstring in PosteriorList Reviewed By: saitcakmak Differential Revision: D55038429
Summary: All internal calls to this have been updated to use `distribution` instead, including in subclasses (`HigherOrderGPPosterior`, `GaussianMixturePosterior`, `MultiTaskGPPosterior`, `FullyBayesianPosterior`) Differential Revision: D55092855
esantorella
force-pushed
the
export-D55092855
branch
from
2d6b23e
to
5c9af85
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55092855 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 197 197
Lines 17163 17146 -17
==========================================
- Hits 17159 17142 -17
Misses 4 4 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in ea23802. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: All internal calls to this have been updated to use
distributioninstead, including in subclasses (HigherOrderGPPosterior,GaussianMixturePosterior,MultiTaskGPPosterior,FullyBayesianPosterior)Differential Revision: D55092855