Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python upgrade guide #1826

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

atalman
Copy link
Contributor

@atalman atalman commented May 21, 2024

Create Python upgrade guide

Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good at a high level but I think we should align this with the general process where we expect wheels to be done way ahead. Also build being enabled before tests are enabled.
This doc doesn't have to contain the details of these other components but should most likely contain things like: "wait for Core to fix test" or "wait for core to enable compilation". In between the steps.

@atalman wrote: Normally we do not really need to wait for core to fix the tests in CI. We land the change, however create an issue for core team, as in step 5 of this runbook. Also green signal is the requirement for each PR land. Hence in theory if we get green signal at each step of this guide, we should be good.

PYTHON_UPGRADE_GUIDE.MD Outdated Show resolved Hide resolved

1) Python package is available via python ftp [here](https://www.python.org/ftp/python/) - This is minimal requirement for all wheel builds

2) Python package is available via anaconda [here](https://anaconda.org/anaconda/python/files) - This is required for conda builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to start before this is ready so this is not really a requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let me add a the statement about that conda build can be done independently

2) Python package is available via anaconda [here](https://anaconda.org/anaconda/python/files) - This is required for conda builds

## 1. Maintain Progress and Updates
Make an issue to track the progress, for example CUDA issue [#56721: Support 11.3](https://github.com/pytorch/pytorch/issues/56721). This is especially important as many PyTorch external users are interested in Pytorch upgrades.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: most likely should be changed to what we do for 3.13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think once we do 3.13. We should update this guide to 3.13 PRs

PYTHON_UPGRADE_GUIDE.MD Outdated Show resolved Hide resolved
@atalman atalman requested a review from albanD May 21, 2024 15:45
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

PYTHON_UPGRADE_GUIDE.MD Outdated Show resolved Hide resolved
PYTHON_UPGRADE_GUIDE.MD Outdated Show resolved Hide resolved
@atalman atalman merged commit 91eb7c4 into pytorch:main May 21, 2024
2 checks passed
@atalman atalman deleted the python_update_runbook branch May 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants