Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cpython 3.7.5 from Docker #1885

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 25, 2024

try to mitigate Docker build issue

Error:

#37 285.1 ERROR: This script does not work on Python 3.7 The minimum supported Python version is 3.8. Please use https://bootstrap.pypa.io/pip/3.7/get-pip.py instead.
#37 ERROR: process "/bin/sh -c bash build_scripts/build.sh && rm -r build_scripts" did not complete successfully: exit code: 1
------
 > [python 3/3] RUN bash build_scripts/build.sh && rm -r build_scripts:
268.9 + make install
284.8 + [[ --enable-shared == \-\-\e\n\a\b\l\e\-\s\h\a\r\e\d ]]
284.8 + patchelf --set-rpath '$ORIGIN/../lib' /opt/_internal/cpython-3.7.5/bin/python3
284.8 + popd
284.8 + rm -rf Python-3.7.5
284.8 /
285.0 + '[' -e /opt/_internal/cpython-3.7.5/bin/python3 ']'
285.0 + ln -s python3 /opt/_internal/cpython-3.7.5/bin/python
285.0 + /opt/_internal/cpython-3.7.5/bin/python get-pip.py
285.1 ERROR: This script does not work on Python 3.7 The minimum supported Python version is 3.8. Please use https://bootstrap.pypa.io/pip/3.7/get-pip.py instead.

Can be seen here: https://github.com/pytorch/builder/actions/runs/9632759825/job/26630628070

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty ssl-check.py (or example why it is needed), otherwise LGTM

@atalman atalman merged commit 9b5c267 into pytorch:main Jun 25, 2024
26 checks passed
@atalman atalman deleted the remove_python_37 branch June 25, 2024 15:54
jithunnair-amd pushed a commit to ROCm/builder that referenced this pull request Jul 3, 2024
* Remove cpython 3.7.5 from Docker

* Advance build.sh scrript

* fix_folder

* More_py37_refactor

* wrong_file

Cherry-picked from pytorch@9b5c267
jithunnair-amd pushed a commit to ROCm/builder that referenced this pull request Jul 19, 2024
* Remove cpython 3.7.5 from Docker

* Advance build.sh scrript

* fix_folder

* More_py37_refactor

* wrong_file

Cherry-picked from pytorch@9b5c267
jithunnair-amd pushed a commit to ROCm/builder that referenced this pull request Jul 19, 2024
* Remove cpython 3.7.5 from Docker

* Advance build.sh scrript

* fix_folder

* More_py37_refactor

* wrong_file

Cherry-picked from pytorch@9b5c267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants