fix docstring - multiple or #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarineK
reviewed
Sep 24, 2022
| @@ -724,7 +724,7 @@ def _compute_jacobian_wrt_params( | |||
| It is unpacked before passing to `model`, so it must be a tuple. The | |||
| individual elements of `inputs` can be anything. | |||
| labels (Tensor or None): Labels for input if computing a loss function. | |||
| loss_fn (torch.nn.Module or Callable or None): The loss function. If a library | |||
| loss_fn (torch.nn.Module or Callable, optional): The loss function. If a library | |||
There was a problem hiding this comment.
@aobo-y, for the case labels (Tensor or None) it is also option like loss_fn ? Do we want to fix that too. Line 795 is similar.
There was a problem hiding this comment.
Oh yes, definitely, I can fix it too. Coz my original intention was to fix lines with multiple or connections, that line did not pop up in my regex search.
|
@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
vivekmig
approved these changes
Oct 12, 2022
Infinity-ops
added a commit
to Infinity-ops/captum
that referenced
this pull request
Oct 13, 2022
fix docstring - multiple or (pytorch#1034)
cyrjano
pushed a commit
to cyrjano/captum
that referenced
this pull request
Oct 13, 2022
Summary: use only one `or` for multiple types Pull Request resolved: pytorch#1034 Reviewed By: vivekmig Differential Revision: D40030553 Pulled By: aobo-y fbshipit-source-id: 4fec520d82e3b7c200f6fdc50fd66e8ae71da8c1
cyrjano
pushed a commit
to cyrjano/captum
that referenced
this pull request
Oct 13, 2022
Summary: use only one `or` for multiple types Pull Request resolved: pytorch#1034 Reviewed By: vivekmig Differential Revision: D40030553 Pulled By: aobo-y fbshipit-source-id: 4fec520d82e3b7c200f6fdc50fd66e8ae71da8c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use only one
orfor multiple types