Self Influence only on self_influence method.
#1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently self influence in TracInCP can be calculated either by calling the `self_influence` method with an `inputs_dataset` or calling `influence` without an `inputs_dataset`. These changes unify the api so that only `self_influence` method is needed to calculate self influence. Test Plan: - Run existing tracinCP unit tests. - Add and execute unit test for validation of arguments: test_tracin_validation. - Update and execute `TracInCP_Tutorial` notebook. Reviewers: Subscribers: Tasks: Tags:
|
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Some documentation fixes. Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently self influence in TracInCP can be calculated either by calling the
self_influencemethod with aninputs_datasetor callinginfluencewithout aninputs_dataset. These changes unify the api so that onlyself_influencemethod is needed to calculate self influence.Test Plan:
TracInCP_Tutorialnotebook. Reviewers:Subscribers:
Tasks:
Tags: