Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self Influence only on self_influence method. #1069

Closed
wants to merge 5 commits into from
Closed

Self Influence only on self_influence method. #1069

wants to merge 5 commits into from

Commits on Nov 15, 2022

  1. Self Influence only on self_influence method. 

    Summary:
Currently self influence in TracInCP can be calculated
either by calling the `self_influence` method with an
`inputs_dataset` or calling `influence` without an `inputs_dataset`.
These changes unify the api so that only `self_influence`
method is needed to calculate self influence.

Test Plan:
 - Run existing tracinCP unit tests.
 - Add and execute unit test for validation of arguments:
 test_tracin_validation.
 - Update and execute `TracInCP_Tutorial` notebook.
Reviewers:

Subscribers:

Tasks:

Tags:
    @cyrjano
    cyrjano committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cdc2efe View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Improve documentation as suggested per comments. 

    Summary:
Some documentation fixes.
Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @cyrjano
    cyrjano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ab0d700 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into self_influence

    @cyrjano
    cyrjano committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    9ec4bf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge remote-tracking branch 'upstream/master' into self_influence

    @cyrjano
    cyrjano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    cc31aee View commit details
    Browse the repository at this point in the history

  2. Update error message. 

    Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
    @cyrjano
    cyrjano committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9f4ac94 View commit details
    Browse the repository at this point in the history