Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't take Tensor by value #38

Closed
ezyang opened this issue May 21, 2021 · 0 comments
Closed

Don't take Tensor by value #38

ezyang opened this issue May 21, 2021 · 0 comments

Comments

@ezyang
Copy link
Contributor

ezyang commented May 21, 2021

Better to take it by reference, e.g., here

https://github.com/zou3519/functorch/blob/68df44f7cdb72864d5e43674357bca7a57b81220/functorch/csrc/PythonKey.cpp#L28
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ezyang