Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an optional EXPENSIVE label for tests #2407

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

jackm321
Copy link
Contributor

Description:
Create a set of tests with the EXPENSIVE label (add_glow_test(EXPENSIVE ...)) and only run those tests with ninja check_expensive. Make all existing OutputCheck tests use the EXPENSIVE label. Build all tests all the time, only run OutputCheck tests when all build requirements were satisfied.

Testing:
ninja check
ninja check_expensive

Documentation:
Comments, Updated docs

@jackm321 jackm321 changed the title Create an EXPENSIVE label for test and only run those with ninja check_expensive Create an EXPENSIVE label for tests and only run those with ninja check_expensive Feb 18, 2019
@jackm321 jackm321 changed the title Create an EXPENSIVE label for tests and only run those with ninja check_expensive Create an EXPENSIVE label for tests and only run those with ninja check_expensive Feb 18, 2019
@jackm321 jackm321 changed the title Create an EXPENSIVE label for tests and only run those with ninja check_expensive Create an EXPENSIVE label for tests and only run those with "ninja check_expensive" command Feb 18, 2019
@jackm321 jackm321 changed the title Create an EXPENSIVE label for tests and only run those with "ninja check_expensive" command Create an optional EXPENSIVE label for tests and only run those with "ninja check_expensive" command Feb 18, 2019
@jackm321 jackm321 changed the title Create an optional EXPENSIVE label for tests and only run those with "ninja check_expensive" command Create an optional EXPENSIVE label for tests Feb 18, 2019
@jackm321
Copy link
Contributor Author

If we like this approach, maybe we should think about adding some more tests to the EXPENSIVE list like:

MLTest: 149.27 sec
BackendCorrectnessTest: 49.35 sec
OperatorTest: 29.83 sec
QuantizationTest: 21.86 sec
ConvTest: 16.13 sec
GradCheckTest: 7.63 sec
BackendTest: 7.49 sec

@nickgg
Copy link
Contributor

nickgg commented Feb 19, 2019

Which target does the CI run?

@bertmaher
Copy link
Contributor

For things like MLTest, the biggest issue is that it's not properly parallelized, so that one test is a long pole that blocks everything else. If you run our test suite with proper parallelization (like using gtest-parallel), then everything runs pretty quickly.

I wonder if there's a way to get cmake to use gtest-parallel?

@jackm321
Copy link
Contributor Author

@nickgg CI would run check and check_expensive
@bertmaher that's interesting about gtest-parallel, we should look into that, I can create a task for it.

Copy link
Contributor

@nickgg nickgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@jackm321 jackm321 merged commit 0253352 into pytorch:master Feb 19, 2019
@jackm321 jackm321 mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants