[habana] Stub getMemInfo #2688
Merged
[habana] Stub getMemInfo #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertmaher
force-pushed
the
D14816916-6284d1b5
branch
from
88e102a
to
5b3cf9b
Compare
nadavrot
reviewed
Apr 9, 2019
| @@ -100,6 +96,26 @@ llvm::Error HabanaDeviceManager::init() { | |||
| return llvm::Error::success(); | |||
| } | |||
|
|
|||
| llvm::Error HabanaDeviceManager::updateMemoryUsage() { | |||
| // TODO: use synGetMemInfo once implemented | |||
Summary: I took this idea from @jackmontgomery, we need to actually estimate memory or the host manager doesn't work. Differential Revision: D14816916
bertmaher
force-pushed
the
D14816916-6284d1b5
branch
from
5b3cf9b
to
5dfc4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I took this idea from @jackm321, we need to actually estimate
memory or the host manager doesn't work.
Differential Revision: D14816916