simple arg name mismatch for mnist tensorboard example

[DhDeepLIT]

🐛 Bug description

Example for mnist with tensorboard does not work due to wrong arg name.

git clone https://github.com/pytorch/ignite
cd examples/mnist
python3.6 mnist_with_tensorboard.py --log_dir=/tmp/tensorboard_logs
Traceback (most recent call last):
File "mnist_with_tensorboard.py", line 161, in
run(args.batch_size, args.val_batch_size, args.epochs, args.lr, args.momentum, args.log_interval, args.log_dir)
File "mnist_with_tensorboard.py", line 89, in run
writer = create_summary_writer(model, train_loader, log_dir)
File "mnist_with_tensorboard.py", line 76, in create_summary_writer
writer = SummaryWriter(logdir=log_dir)
TypeError: init() got an unexpected keyword argument 'logdir'

Traceback (most recent call last):
File "mnist_with_tensorboard.py", line 161, in
run(args.batch_size, args.val_batch_size, args.epochs, args.lr, args.momentum, args.log_interval, args.log_dir)
File "mnist_with_tensorboard.py", line 89, in run
writer = create_summary_writer(model, train_loader, log_dir)
File "mnist_with_tensorboard.py", line 76, in create_summary_writer
writer = SummaryWriter(logdir=log_dir)
TypeError: init() got an unexpected keyword argument 'logdir'

Just something that runs ....

Environment

Ubuntu 18.06 LTS, dual 1080Ti, 32 Go RAM, intel i7-2600K

pip3.6 install torch
pip3.6 install torchvision
pip3.6 install tensorboard

pip3.6 list | grep -E 'tensor'|'torch'
pytorch-ignite 0.4.0
tensorboard 2.2.0
tensorboard-plugin-wit 1.6.0.post2
torch 1.4.0
torchvision 0.5.0

[vfdev-5]

@DhDeepLIT thanks for the report !
It looks like to be related to different signatures of SummayWriter between torch internal tensorboard and tensorboardX:

• https://pytorch.org/docs/stable/tensorboard.html#torch.utils.tensorboard.writer.SummaryWriter
  vs
• https://github.com/lanpa/tensorboardX/blob/master/tensorboardX/writer.py#L210

[vfdev-5]

@DhDeepLIT if you would like to contribute, do not hesitate to send a PR with a fix.
Seems like there are only two places where need to change: logdir -> log_dir:

• mnist_with_tensorboard.py
• mnist_save_resume_engine.py

Thanks !