Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unittests.yml #879

Merged
merged 1 commit into from Apr 4, 2020
Merged

Update unittests.yml #879

merged 1 commit into from Apr 4, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 4, 2020

Description:
This PR is to enforce our tests while using native torch tensorboard. It is related to the recent bug #878 . Once it is fixed we can merge this one.

  • Removed tensorboardX to test with torch tensorboard

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Removed tensorboardX to test with torch tensorboard
@sdesrozis
Copy link
Contributor

We can’t do both ? With tensorboardX and without (using torch) ?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 4, 2020

We can’t do both ? With tensorboardX and without (using torch) ?

To do both, we need to uninstall tensorboardX and rerun all unit tests and smoke tests.
Idea is to keep Travis CI working with TbX and GithubCI with native torch tensorboard (as it will be probably the future).

@vfdev-5 vfdev-5 merged commit 08b062c into master Apr 4, 2020
@vfdev-5 vfdev-5 deleted the check_with_torch_tb branch April 4, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants