Add TrainsLogger #1020
Add TrainsLogger #1020
Conversation
|
@jkhenning thanks for the PR ! |
|
@jkhenning there is also a redefinition of test flake error to fix : https://travis-ci.org/github/pytorch/ignite/jobs/684300841#L238 |
|
Code looks clean and I didn't see any issues. One question for @jkhenning: why are you pinning to the release candidate in the |
|
@erip The reason for the release candidate is a small adjustment I had to make in the Trains binding code to make the integration cleaner. I wanted to make sure this PR was cleared so I can release the official Trains v0.14.3. |
| if artifact: | ||
| return artifact.get_local_copy() | ||
| self.task.get_logger().report_text("Can not find artifact {}".format(filename)) | ||
| return None |
|
Excellent. I don't have write access, so @vfdev-5 will have to make sure this doesn't get merged until the new trains release is cut. |
| - ``TaskTypes.train`` | ||
| - ``TaskTypes.testing`` | ||
| - ``TaskTypes.inference`` | ||
| report_freq (int): Optional. Histogram processing frequency (handle hist values every X calls to the handler). |
There was a problem hiding this comment.
@jkhenning I was checking documentation layout of TrainsLogger and seems like I missed those args:
- report_freq
- histogram_update_freq_multiplier
In ignite we can easily filter out how frequently call an event handler, so, does report_freq param mean to call WeightsScalarHandler every report_freq times :
trains_logger.attach(trainer,
log_handler=WeightsScalarHandler(model),
event_name=Events.ITERATION_COMPLETED(every=report_freq))?
There was a problem hiding this comment.
Hi @vfdev-5 ,
I think you're right, and it was my mistake to expose these values (they are related to the internal working of how we process and average the reports internally). I'll open a PR and remove them, if you'd like.
There was a problem hiding this comment.
Well, if it does almost the same as event filtering, so, yes please send a PR and remove them...
Fixes #892
Description:
Check list: