Skip to content

Commit

Permalink
[Release/2.3] Set py3.x build-environment name consistently (#123446)
Browse files Browse the repository at this point in the history
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6
Pull Request resolved: #122247
Approved by: https://github.com/malfet

(cherry picked from commit 6fefc52)

Co-authored-by: Huy Do <huydhn@gmail.com>
  • Loading branch information
pytorchbot and huydhn committed Apr 5, 2024
1 parent 634cf50 commit 23961ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/inductor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
name: linux-jammy-cpu-py3.8-gcc11-inductor
uses: ./.github/workflows/_linux-build.yml
with:
build-environment: linux-jammy-py3_8-gcc11-build
build-environment: linux-jammy-py3.8-gcc11-build
docker-image-name: pytorch-linux-jammy-py3.8-gcc11-inductor-benchmarks
test-matrix: |
{ include: [
Expand All @@ -135,7 +135,7 @@ jobs:
uses: ./.github/workflows/_linux-test.yml
needs: linux-jammy-cpu-py3_8-gcc11-inductor-build
with:
build-environment: linux-jammy-py3_8-gcc11-build
build-environment: linux-jammy-py3.8-gcc11-build
docker-image: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.docker-image }}
test-matrix: ${{ needs.linux-jammy-cpu-py3_8-gcc11-inductor-build.outputs.test-matrix }}
secrets:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ jobs:
name: linux-focal-py3_8-clang9-xla
uses: ./.github/workflows/_linux-build.yml
with:
build-environment: linux-focal-py3_8-clang9-xla
build-environment: linux-focal-py3.8-clang9-xla
docker-image-name: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/xla_base:v1.1-lite
test-matrix: |
{ include: [
Expand All @@ -323,7 +323,7 @@ jobs:
uses: ./.github/workflows/_linux-test.yml
needs: linux-focal-py3_8-clang9-xla-build
with:
build-environment: linux-focal-py3_8-clang9-xla
build-environment: linux-focal-py3.8-clang9-xla
docker-image: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.docker-image }}
test-matrix: ${{ needs.linux-focal-py3_8-clang9-xla-build.outputs.test-matrix }}

Expand Down

0 comments on commit 23961ce

Please sign in to comment.