Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set py3.x build-environment name consistently #122247

Closed
wants to merge 1 commit into from
Closed

Set py3.x build-environment name consistently #122247

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 19, 2024

#122157 checks for the Python version using "$BUILD_ENVIRONMENT" != *py3.8*, but some build environment uses a different style with py3_8 instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6

@huydhn huydhn requested a review from malfet March 19, 2024 23:42
@huydhn huydhn requested a review from a team as a code owner March 19, 2024 23:42
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 19, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122247

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit f40dd66 with merge base a843bbd (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 19, 2024
malfet
malfet approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@malfet
Copy link
Contributor

malfet commented Mar 19, 2024

@pytorchbot merge -f "It's broken in trunk already, let's try to fwd fix it"

@malfet
Copy link
Contributor

malfet commented Mar 19, 2024

@jeanschmidt FYI we still have a forked-PR problem, see https://github.com/pytorch/pytorch/actions/runs/8351590342/job/22860190399?pr=122247

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor Author

huydhn commented Mar 20, 2024

@jeanschmidt FYI we still have a forked-PR problem, see https://github.com/pytorch/pytorch/actions/runs/8351590342/job/22860190399?pr=122247

Look like I need to revert an additional change here. This is a new PR coming from @clee2000 IIRC

@huydhn
Copy link
Contributor Author

huydhn commented Mar 20, 2024

@pytorchbot drci

@huydhn
Copy link
Contributor Author

huydhn commented Mar 20, 2024

@clee2000 I assume that failing llm retrieval job will not stop subsequent CI test jobs to continue, so I have added a flaky rule for that here https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json#L63-L67 in case we don't want to revert #121836

@clee2000
Copy link
Contributor

@clee2000 I assume that failing llm retrieval job will not stop subsequent CI test jobs to continue, so I have added a flaky rule for that here https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json#L63-L67 in case we don't want to revert #121836

Thanks, I've changed the bucket settings details in #122279 so the aws credentials aren't needed anymore, anyone experiencing the issue can resolve it by rebasing as well now

@atalman
Copy link
Contributor

atalman commented Apr 5, 2024

@pytorchbot cherry-pick --onto release/2.3 -c critical

pytorchbot pushed a commit that referenced this pull request Apr 5, 2024
@huydhn @pytorchbot
Set py3.x build-environment name consistently (#122247)
66d69a3 
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6
Pull Request resolved: #122247
Approved by: https://github.com/malfet

(cherry picked from commit 6fefc52)
@pytorchbot
Copy link
Collaborator

Cherry picking #122247

The cherry pick PR is at #123446 and it is recommended to link a critical cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

@atalman atalman mentioned this pull request Apr 5, 2024
Closed
malfet pushed a commit that referenced this pull request Apr 5, 2024
@pytorchbot @huydhn
[Release/2.3] Set py3.x build-environment name consistently (#123446)
23961ce 
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6
Pull Request resolved: #122247
Approved by: https://github.com/malfet

(cherry picked from commit 6fefc52)

Co-authored-by: Huy Do <huydhn@gmail.com>
pytorch-bot bot pushed a commit that referenced this pull request Apr 22, 2024
@huydhn
Set py3.x build-environment name consistently (#122247)
cecf089 
#122157 checks for the Python version using `"$BUILD_ENVIRONMENT" != *py3.8*`, but some build environment uses a different style with `py3_8` instead causing numpy 2.x to be installed there wrongly, i.e. https://hud.pytorch.org/pytorch/pytorch/commit/03b987fe3fa93f398c0af5b40e512950c39a7cb6
Pull Request resolved: #122247
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/inductor Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@huydhn @malfet @pytorchmergebot @clee2000 @atalman @pytorchbot