-
Notifications
You must be signed in to change notification settings - Fork 22.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[vmap] symintify alias and squeeze (#107577)
Following tests now pass (both ops call into `alias` on certain paths) ``` PYTORCH_TEST_WITH_DYNAMO=1 pytest test/functorch/test_vmap.py -k test_squeeze -v PYTORCH_TEST_WITH_DYNAMO=1 pytest test/functorch/test_vmap.py -k test_conj -v ``` NOTE: Ideally, this symint version should work with non symint version as well but that would mean changes at multiple places. Wanted to get a review for this fix before-hand. Other sites which use the `IntArrayRef` overload. https://github.com/pytorch/pytorch/blob/5f56c4fb32dbb5dd4e75a3a3a9726ae95931926d/aten/src/ATen/native/TensorShape.cpp#L1707-L1713 `view_impl` is called from `view` and `_unsafe_view`. https://github.com/pytorch/pytorch/blob/5f56c4fb32dbb5dd4e75a3a3a9726ae95931926d/aten/src/ATen/native/TensorShape.cpp#L3295-L3306 Pull Request resolved: #107577 Approved by: https://github.com/zou3519
- Loading branch information
1 parent
138fafe
commit 50fa588
Showing
2 changed files
with
28 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters