Skip to content

Commit

Permalink
fix: Fixed typing of bool in _ConvNd (#46828)
Browse files Browse the repository at this point in the history
Summary:
Hello there 👋

I do believe there is some typo in the typing of the `bool` argument of `_ConvNd`constructor.
The typing of the attribute is correct, but the constructor argument, while being the same way, is not the value that will be assigned to `self.bias`.

This PR simply corrects that.

Any feedback is welcome!

Pull Request resolved: #46828

Reviewed By: izdeby

Differential Revision: D24550435

Pulled By: ezyang

fbshipit-source-id: ab10f1a5b29a912cb23fc321a51e78b04a8391e3
  • Loading branch information
frgfm authored and facebook-github-bot committed Oct 28, 2020
1 parent cd8ed93 commit c886c7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion torch/nn/modules/conv.py
Expand Up @@ -69,7 +69,7 @@ def __init__(self,
transposed: bool,
output_padding: _size_1_t,
groups: int,
bias: Optional[Tensor],
bias: bool,
padding_mode: str) -> None:
super(_ConvNd, self).__init__()
if in_channels % groups != 0:
Expand Down

0 comments on commit c886c7f

Please sign in to comment.