fix: Fixed typing of bool in _ConvNd #46828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46828 +/- ##
==========================================
- Coverage 68.96% 68.96% -0.01%
==========================================
Files 434 434
Lines 55996 55996
==========================================
- Hits 38619 38618 -1
- Misses 17377 17378 +1 |
izdeby
added
the
triaged
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there 馃憢
I do believe there is some typo in the typing of the
boolargument of_ConvNdconstructor.The typing of the attribute is correct, but the constructor argument, while being named the same way, is not the value that will be assigned to
self.bias.This PR simply corrects that.
Any feedback is welcome!