-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic operator tests to run for primtorch ops #107335
Labels
module: primTorch
module: testing
Issues related to the torch.testing module (not tests)
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Comments
This was referenced Aug 16, 2023
ezyang
added
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
module: testing
Issues related to the torch.testing module (not tests)
module: primTorch
labels
Aug 18, 2023
Hi, I chatted about this with @ngimel and avoiding refs being tested this way was partially about avoiding inflating test time. So it would be good to make sure we aren't making test times a lot worse. |
pytorchmergebot
pushed a commit
that referenced
this issue
Aug 18, 2023
Fixes #107335. Part of breakdown of #104489. Pull Request resolved: #107336 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
that referenced
this issue
Aug 19, 2023
Fixes #107335. The skips were updated for the _ref ops to match those for eager mode where necessary. Part of breakdown of #104489. Pull Request resolved: #107338 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
to wenzhe-nrv/pytorch
that referenced
this issue
Aug 19, 2023
…7338) Fixes pytorch#107335. The skips were updated for the _ref ops to match those for eager mode where necessary. Part of breakdown of pytorch#104489. Pull Request resolved: pytorch#107338 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
that referenced
this issue
Aug 23, 2023
Fixes #107335. The skips were updated for the _ref ops to match those for eager mode where necessary. Part of breakdown of #104489. Pull Request resolved: #107345 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: primTorch
module: testing
Issues related to the torch.testing module (not tests)
triaged
This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Issue description
Currently most of the operator groupings in common_method_invocations don't include the reference operators and this could lead to unintended mismatch in operator functionality between eager ops and primtorch ops slipping through. Some cases have already been seen of this while creating #104489. This is issue is being created in order to track and breakdown the changes to multiple pull requests for more manageable pieces for review. The
sparse_*
groupings cannot be currently updated as it seems that sparse tensor support for primtorch is is not yet complete.pytorch/torch/testing/_internal/common_methods_invocations.py
Lines 20638 to 20651 in 8507b22
unary_ufuncs
groupingsbinary_ufuncs
groupingsspectral_funcs
groupingssparse_unary_ufuncs
groupingssparse_csr_unary_ufuncs
groupingssparse_reduction_ops
groupingsshape_funcs
groupingsreduction_ops
groupingscc @ezyang @mruberry @lezcano @peterbell10
The text was updated successfully, but these errors were encountered: