Skip to content

Update reduction_ops groupings to include primtorch types #107338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update reduction_ops groupings to include primtorch types #107338

wants to merge 2 commits into from

Conversation

ekamiti
Copy link
Contributor

@ekamiti ekamiti commented Aug 16, 2023 •
edited
Loading

Fixes #107335. The skips were updated for the _ref ops to match those for eager mode where necessary. Part of breakdown of #104489.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107338

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 3424d65 with merge base 2d7a062 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ekamiti ekamiti changed the title Update reduciton_ops groupings to include primtorch types Update reduction_ops groupings to include primtorch types Aug 17, 2023
@ekamiti ekamiti marked this pull request as ready for review August 18, 2023 00:59
ezyang
ezyang reviewed Aug 18, 2023
View reviewed changes
@ezyang
Copy link
Contributor

ezyang commented Aug 18, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the topic: not user facing topic category label Aug 18, 2023
@ezyang
Copy link
Contributor

ezyang commented Aug 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@ekamiti ekamiti mentioned this pull request Aug 18, 2023
Open
@ekamiti
Copy link
Contributor Author

ekamiti commented Aug 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to wenzhe-nrv/pytorch that referenced this pull request Aug 19, 2023
@ekamiti @pytorchmergebot
Update reduction_ops groupings to include primtorch types (pytorch#10…
609cb84 
…7338)

Fixes pytorch#107335. The skips were updated for the _ref ops to match those for eager mode where necessary. Part of breakdown of pytorch#104489.

Pull Request resolved: pytorch#107338
Approved by: https://github.com/ezyang
@ekamiti ekamiti deleted the reduction_ops branch August 24, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update generic operator tests to run for primtorch ops

4 participants

@ekamiti @ezyang @pytorchmergebot @pytorchbot