-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical problem in Torch.add function #2529
Comments
Hamid, please read about the semantics of broadcasting. This is correct behavior. |
@soumith Thank you, Soumith. But in this special case, how can I get [1, 16, 32, 64, 64] as output size? |
you have to define how you want those leading dimensions to be added, but one way to get that output size would be to do something like:
|
@gchanan Thank you :) |
houseroad
added a commit
to houseroad/pytorch
that referenced
this issue
Jan 14, 2020
…740f8f (pytorch#32125) Summary: Pull Request resolved: pytorch#32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (pytorch#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (pytorch#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (pytorch#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (pytorch#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (pytorch#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (pytorch#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (pytorch#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (pytorch#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (pytorch#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (pytorch#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (pytorch#2516) <Ashwini Khade> Test Plan: cont build Differential Revision: D19380034 fbshipit-source-id: 1ea677eed6779d2b3f8e4683225ba856c68159cd
facebook-github-bot
pushed a commit
that referenced
this issue
Jan 14, 2020
…740f8f (#32125) Summary: Pull Request resolved: #32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (#2516) <Ashwini Khade> Test Plan: cont build Reviewed By: benoitsteiner Differential Revision: D19380034 fbshipit-source-id: ddce8450864a611773b2a32e2f0254c9bb6b6906
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this issue
Jan 30, 2020
…740f8f (pytorch#32125) Summary: Pull Request resolved: pytorch#32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (pytorch#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (pytorch#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (pytorch#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (pytorch#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (pytorch#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (pytorch#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (pytorch#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (pytorch#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (pytorch#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (pytorch#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (pytorch#2516) <Ashwini Khade> Test Plan: cont build Reviewed By: benoitsteiner Differential Revision: D19380034 fbshipit-source-id: ddce8450864a611773b2a32e2f0254c9bb6b6906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have found critical issue in torch.add(x,y) function. It seems broadcasting feature does not work well for special case:
The size of z should be [1, 16, 32, 64, 64] but it is [16, 16, 32, 64, 64]? WHY?
Whatever number instead of 1 works well? Any idea?
The text was updated successfully, but these errors were encountered: