Fix bugs caused by flatten_parameters() #2537

apaszke · 2017-08-25T14:06:24Z

eriche2016 · 2018-01-12T02:02:22Z

for temporary solution, replace this line as below:

unique_data_ptrs = set(p.data_ptr() if not hasattr(p, 'grad') else p.data.data_ptr() for l in self.all_weights for p in l)

see the reason causes this problem, see here.

apaszke · 2018-01-12T11:30:35Z

Or just update PyTorch. All these fixes are merged

…740f8f (pytorch#32125) Summary: Pull Request resolved: pytorch#32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (pytorch#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (pytorch#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (pytorch#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (pytorch#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (pytorch#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (pytorch#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (pytorch#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (pytorch#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (pytorch#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (pytorch#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (pytorch#2516) <Ashwini Khade> Test Plan: cont build Differential Revision: D19380034 fbshipit-source-id: 1ea677eed6779d2b3f8e4683225ba856c68159cd

…740f8f (#32125) Summary: Pull Request resolved: #32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (#2516) <Ashwini Khade> Test Plan: cont build Reviewed By: benoitsteiner Differential Revision: D19380034 fbshipit-source-id: ddce8450864a611773b2a32e2f0254c9bb6b6906

…740f8f (pytorch#32125) Summary: Pull Request resolved: pytorch#32125 Previous import was 57ebc587fcf3913b4be93653b0dd58c686447298 Included changes: - **[65020daa](onnx/onnx@65020daa)**: better error message for undefined inputs (pytorch#2540) <Yuxin Wu> - **[8afff0e9](onnx/onnx@8afff0e9)**: bump ORT version (pytorch#2538) <Lu Fang> - **[3d9ca57e](onnx/onnx@3d9ca57e)**: fix name of directory (pytorch#2537) <Prasanth Pulavarthi> - **[df8fa2c9](onnx/onnx@df8fa2c9)**: Repository guidelines (pytorch#2539) <Prasanth Pulavarthi> - **[49cc2f02](onnx/onnx@49cc2f02)**: Update CircleCI job to use Python3.6 (pytorch#2527) <bddppq> - **[25ff79a4](onnx/onnx@25ff79a4)**: Fix wrong model version, it's not 12 (the onnx_opset_version()), not 11 (the opset version of the latest stable), but 10 (pytorch#2478) <daquexian> - **[7cebaed5](onnx/onnx@7cebaed5)**: Fix Windows py3.5 CI (pytorch#2529) <bddppq> - **[eddae00e](onnx/onnx@eddae00e)**: Correct the order of arguments of InferShapes (pytorch#2500) <Shinichiro Hamaji> - **[41b5afe6](onnx/onnx@41b5afe6)**: Include <ostream> in common/status.h (pytorch#2519) <Casey Carter> - **[423f1977](onnx/onnx@423f1977)**: add 8 bit support to maxpool op (pytorch#2510) <Ashwini Khade> - **[78593c2f](onnx/onnx@78593c2f)**: add 8 bit support to reducemin and reducemax ops (pytorch#2516) <Ashwini Khade> Test Plan: cont build Reviewed By: benoitsteiner Differential Revision: D19380034 fbshipit-source-id: ddce8450864a611773b2a32e2f0254c9bb6b6906

Fix bugs caused by flatten_parameters()

24c4375

soumith approved these changes Aug 25, 2017

View reviewed changes

soumith merged commit f250815 into master Aug 25, 2017

soumith deleted the cudnn_rnn branch August 25, 2017 15:09

ezyang added the open source label Jun 24, 2019

houseroad mentioned this pull request Jan 13, 2020

Automatic update of fbcode/onnx to 65020daafa9183c769938b4512ce543fd5740f8f #32125

Closed

samnordmann pushed a commit to samnordmann/pytorch that referenced this pull request Mar 6, 2023

Fix stop predicate (pytorch#2537)

a40ef69

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bugs caused by flatten_parameters() #2537

Fix bugs caused by flatten_parameters() #2537

apaszke commented Aug 25, 2017

eriche2016 commented Jan 12, 2018

apaszke commented Jan 12, 2018

Fix bugs caused by flatten_parameters() #2537

Fix bugs caused by flatten_parameters() #2537

Conversation

apaszke commented Aug 25, 2017

eriche2016 commented Jan 12, 2018

apaszke commented Jan 12, 2018