Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch_linux_xenial_cuda9_cudnn7_py3_build shouldn't build documentation #32058

Closed
zou3519 opened this issue Jan 10, 2020 · 1 comment
Closed

pytorch_linux_xenial_cuda9_cudnn7_py3_build shouldn't build documentation #32058

zou3519 opened this issue Jan 10, 2020 · 1 comment
Assignees
@zou3519
Labels
module: ci Related to continuous integration module: doc infra Related to pytorch.org/docs, deployment of, and serving triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@zou3519
Copy link
Contributor

zou3519 commented Jan 10, 2020 •
edited

🐛 Bug

pytorch_linux_xenial_cuda9_cudnn7_py3_build appears to build the pytorch docs. See this log.

It probably shouldn't build the docs; that's what the python_doc_push CI job is for.

cc @ezyang @zou3519
@zou3519 zou3519 added module: ci Related to continuous integration module: doc infra Related to pytorch.org/docs, deployment of, and serving labels Jan 10, 2020
@zou3519
Copy link
Contributor Author

zou3519 commented Jan 14, 2020 •
edited

We can delete this:

pytorch/.jenkins/pytorch/build.sh

Lines 208 to 216 in 4a26bb9

# Test documentation build
if [[ "$BUILD_ENVIRONMENT" == *xenial-cuda10.1-cudnn7-py3* ]]; then
pushd docs
# TODO: Don't run this here
pip_install -r requirements.txt || true
LC_ALL=C make html
popd
assert_git_not_dirty
fi

The blame doesn't tell me when we added it. My guess is that before we had a CI docs build job, we relied on the above lines to test that the docs build correctly. Since we now have a separate CI docs build job, we can stop building the docs in our CUDA linux pytorch build.

@zou3519 zou3519 self-assigned this Jan 14, 2020
@zou3519 zou3519 mentioned this issue Jan 14, 2020
Closed
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Stop building documentation in pytorch_linux_xenial_cuda9_cudnn7_py3_…
dcc0ab7 
…build

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the job. With this change,
pytorch_linux_xenial_cuda9_cudnn7_py3_build should run ~10 minutes
faster, giving devs faster signal.

Test Plan:
- Check the pytorch_linux_xenial_cuda9_cudnn7_py3_build on this PR, make
sure it doesn't build the docs.

[ghstack-poisoned]
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Update on "Stop building documentation in pytorch_linux_xenial_cuda*_…
88111b9 
…build"

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the job. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.

[ghstack-poisoned]
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Update on "Stop building documentation in pytorch_linux_xenial_cuda*_…
40b0e13 
…build"

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.

[ghstack-poisoned]
@zhangguanheng66 zhangguanheng66 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 14, 2020
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Update on "Stop building documentation in pytorch_linux_xenial_cuda*_…
6f499ee 
…build"

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.

Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417)

[ghstack-poisoned]
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Update on "Stop building documentation in pytorch_linux_xenial_cuda*_…
a2d99e2 
…build"

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

I needed to modify TestDocs.test_docs inside test_jit.py. This was
incorrectly assuming that the dependencies for the docs exist already;
I modified it to install the dependencies before testing.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.
- Run the modified test_docs locally and check that it passes.

Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417)

[ghstack-poisoned]
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Update on "Stop building documentation in pytorch_linux_xenial_cuda*_…
ffeba56 
…build"

Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

I needed to modify TestDocs.test_docs inside test_jit.py. This was
incorrectly assuming that the dependencies for the docs exist already;
I modified it to install the dependencies before testing.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.
- Run the modified test_docs locally and check that it passes.

Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417)

[ghstack-poisoned]
zou3519 added a commit that referenced this issue Jan 14, 2020
@zou3519
Stop building documentation in pytorch_linux_xenial_cuda*_build
168e6d0 
Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

I needed to modify TestDocs.test_docs inside test_jit.py. This was
incorrectly assuming that the dependencies for the docs exist already;
I modified it to install the dependencies before testing.

Test Plan:
- Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.
- Run the modified test_docs locally and check that it passes.

ghstack-source-id: be4544f704ed3f221a2bc25cfbf93a9f4c6b6674
Pull Request resolved: #32187
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this issue Jan 30, 2020
@zou3519 @facebook-github-bot
Stop building documentation in pytorch_linux_xenial_cuda*_build (pyto…
6917859 
…rch#32187)

Summary:
Pull Request resolved: pytorch#32187

Fixes pytorch#32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.

Differential Revision: D19400417

Pulled By: zou3519

fbshipit-source-id: e8fb2b818146f33330e06760377a9afbc18a71ed
ttumiel pushed a commit to ttumiel/pytorch that referenced this issue Mar 4, 2020
@zou3519 @ttumiel
Stop building documentation in pytorch_linux_xenial_cuda*_build (pyto…
0ded50e 
…rch#32187)

Summary:
Pull Request resolved: pytorch#32187

Fixes pytorch#32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.

Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs.

Differential Revision: D19400417

Pulled By: zou3519

fbshipit-source-id: e8fb2b818146f33330e06760377a9afbc18a71ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zou3519 zou3519

Labels
module: ci Related to continuous integration module: doc infra Related to pytorch.org/docs, deployment of, and serving triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zou3519 @zhangguanheng66