Stop building documentation in pytorch_linux_xenial_cuda*_build #32187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the job. With this change, pytorch_linux_xenial_cuda9_cudnn7_py3_build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the pytorch_linux_xenial_cuda9_cudnn7_py3_build on this PR, make sure it doesn't build the docs. [ghstack-poisoned]
…build" Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the job. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. [ghstack-poisoned]
zou3519
changed the title
…build" Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. [ghstack-poisoned]
yf225
approved these changes
Jan 14, 2020
…build" Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417) [ghstack-poisoned]
…build" Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. I needed to modify TestDocs.test_docs inside test_jit.py. This was incorrectly assuming that the dependencies for the docs exist already; I modified it to install the dependencies before testing. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. - Run the modified test_docs locally and check that it passes. Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417) [ghstack-poisoned]
…build" Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. I needed to modify TestDocs.test_docs inside test_jit.py. This was incorrectly assuming that the dependencies for the docs exist already; I modified it to install the dependencies before testing. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. - Run the modified test_docs locally and check that it passes. Differential Revision: [D19400417](https://our.internmc.facebook.com/intern/diff/D19400417) [ghstack-poisoned]
zou3519
added a commit
that referenced
this pull request
Jan 14, 2020
Fixes #32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. I needed to modify TestDocs.test_docs inside test_jit.py. This was incorrectly assuming that the dependencies for the docs exist already; I modified it to install the dependencies before testing. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. - Run the modified test_docs locally and check that it passes. ghstack-source-id: be4544f704ed3f221a2bc25cfbf93a9f4c6b6674 Pull Request resolved: #32187
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
…rch#32187) Summary: Pull Request resolved: pytorch#32187 Fixes pytorch#32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. Differential Revision: D19400417 Pulled By: zou3519 fbshipit-source-id: e8fb2b818146f33330e06760377a9afbc18a71ed
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…rch#32187) Summary: Pull Request resolved: pytorch#32187 Fixes pytorch#32058. Previously we would build documentation during the pytorch linux cuda build. We don't actually need to do this because we have a dedicated python_doc_build job that builds the docs. With this change, the CUDA build should run ~10 minutes faster, giving devs faster signal. Test Plan: - Check the CUDA (10.1) build on this PR, make sure it doesn't build the docs. Differential Revision: D19400417 Pulled By: zou3519 fbshipit-source-id: e8fb2b818146f33330e06760377a9afbc18a71ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #32058. Previously we would build documentation during the pytorch
linux cuda build. We don't actually need to do this because we have a
dedicated python_doc_build job that builds the docs. With this change,
the CUDA build should run ~10 minutes faster, giving devs faster signal.
I needed to modify TestDocs.test_docs inside test_jit.py. This was
incorrectly assuming that the dependencies for the docs exist already;
I modified it to install the dependencies before testing.
Test Plan:
Differential Revision: D19400417