Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnc] split with mask + reorder writes out of bounds #53093

Closed
bertmaher opened this issue Mar 2, 2021 · 0 comments
Closed

[nnc] split with mask + reorder writes out of bounds #53093

bertmaher opened this issue Mar 2, 2021 · 0 comments
Assignees
@navahgar
Labels
NNC triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
NNC Convolutions

Comments

@bertmaher
Copy link
Contributor

As demonstrated in #53091 SplitUnevenMask. The conditional that is supposed to guard the out-of-bounds access somehow only attaches to the initializer loop, and not the body of the reduction.
@bertmaher bertmaher added the NNC label Mar 2, 2021
@bertmaher bertmaher added this to To Do in NNC Convolutions via automation Mar 2, 2021
@navahgar navahgar self-assigned this Mar 2, 2021
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 2, 2021
@navahgar navahgar mentioned this issue Apr 14, 2021
Closed
NNC Convolutions automation moved this from To Do to Done Apr 21, 2021
krshrimali pushed a commit to krshrimali/pytorch that referenced this issue May 19, 2021
@navahgar
[NNC] Handling conditionals in reorderAxis (pytorch#56063)
7dc17d9 
Summary:
Fixes pytorch#53093

Pull Request resolved: pytorch#56063

Reviewed By: huiguoo

Differential Revision: D27894772

Pulled By: navahgar

fbshipit-source-id: 403b65f20567c27eab73faf670087cfab9885f84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navahgar navahgar

Labels
NNC triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
NNC Convolutions
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NNC] Handling conditionals in reorderAxis navahgar/pytorch
3 participants
@navahgar @bertmaher @zou3519