Skip to content

Conversation

navahgar
Copy link
Contributor

Fixes #53093

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 14, 2021

💊 CI failures summary and remediations

As of commit 259e8ae (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 14, 2021
@navahgar navahgar requested review from bertmaher and huiguoo April 15, 2021 17:02
@navahgar navahgar changed the title [NNC] Handling conditionals in reorder_axis [NNC] Handling conditionals in reorderAxis Apr 20, 2021
Copy link
Contributor Author

@navahgar navahgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed your comment. PTAL.

Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@facebook-github-bot
Copy link
Contributor

@navahgar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #56063 (259e8ae) into master (07653b7) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #56063      +/-   ##
==========================================
+ Coverage   77.09%   77.10%   +0.01%     
==========================================
  Files        1923     1923              
  Lines      190671   190677       +6     
==========================================
+ Hits       146990   147016      +26     
+ Misses      43681    43661      -20     

@facebook-github-bot
Copy link
Contributor

@navahgar merged this pull request in d43d659.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Fixes pytorch#53093

Pull Request resolved: pytorch#56063

Reviewed By: huiguoo

Differential Revision: D27894772

Pulled By: navahgar

fbshipit-source-id: 403b65f20567c27eab73faf670087cfab9885f84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nnc] split with mask + reorder writes out of bounds

3 participants