Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We have not yet implemented the batching rule for aten::where.Scalar. #96741

Closed
TheCleric opened this issue Feb 14, 2023 · 1 comment
Closed

We have not yet implemented the batching rule for aten::where.Scalar. #96741

TheCleric opened this issue Feb 14, 2023 · 1 comment
Assignees
@kshitij12345
Labels
actionable high priority module: functorch Pertaining to torch.func or pytorch/functorch triage review

Comments

@TheCleric
Copy link

TheCleric commented Feb 14, 2023 •
edited by pytorch-bot bot

UserWarning: There is a performance drop because we have not yet implemented the batching rule for aten::where.Scalar. Please file us an issue on GitHub so that we can prioritize its implementation. (Triggered internally at /Users/runner/work/_temp/anaconda/conda-bld/pytorch_1673856678067/work/aten/src/ATen/functorch/BatchedFallback.cpp:84.)

cc @ezyang @gchanan @zou3519 @Chillee @samdow @soumith @kshitij12345 @janeyx99
@zou3519 zou3519 transferred this issue from pytorch/functorch Mar 14, 2023
@zou3519 zou3519 added high priority actionable module: functorch Pertaining to torch.func or pytorch/functorch labels Mar 14, 2023
@zou3519
Copy link
Contributor

zou3519 commented Mar 14, 2023

We should be able to do this. Tentatively marking hi-pri for common operator and likely simple fix.

@kshitij12345 kshitij12345 self-assigned this Mar 14, 2023
@kshitij12345 kshitij12345 mentioned this issue Mar 14, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Mar 23, 2023
@kshitij12345 @cyyever
[functorch] batch rule : few decomposition ops (#96744)
b9a907e 
Fixes pytorch/pytorch#96741

Pull Request resolved: pytorch/pytorch#96744
Approved by: https://github.com/zou3519
cyyever pushed a commit to cyyever/pytorch_private that referenced this issue Mar 27, 2023
@kshitij12345 @cyyever
[functorch] batch rule : few decomposition ops (#96744)
f3dff0b 
Fixes pytorch/pytorch#96741

Pull Request resolved: pytorch/pytorch#96744
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kshitij12345 kshitij12345

Labels
actionable high priority module: functorch Pertaining to torch.func or pytorch/functorch triage review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[functorch] batch rule : few decomposition ops kshitij12345/pytorch
3 participants
@TheCleric @zou3519 @kshitij12345