Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[functorch] batch rule : few decomposition ops #96744

Closed
wants to merge 3 commits into from
Closed

[functorch] batch rule : few decomposition ops #96744

wants to merge 3 commits into from

Conversation

kshitij12345
Copy link
Collaborator

Fixes #96741

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96744

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 32931f0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kshitij12345 kshitij12345 changed the title [functorch] where.Scalar : batch rule [functorch] batch rule : decomposition ops Mar 14, 2023
@kshitij12345 kshitij12345 marked this pull request as ready for review March 14, 2023 15:02
@kshitij12345 kshitij12345 changed the title [functorch] batch rule : decomposition ops [functorch] batch rule : few decomposition ops Mar 14, 2023
@kshitij12345 kshitij12345 added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Mar 14, 2023
zou3519
zou3519 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 15, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@kshitij12345 @cyyever
[functorch] batch rule : few decomposition ops (#96744)
b9a907e 
Fixes pytorch/pytorch#96741

Pull Request resolved: pytorch/pytorch#96744
Approved by: https://github.com/zou3519
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@kshitij12345 @cyyever
[functorch] batch rule : few decomposition ops (#96744)
f3dff0b 
Fixes pytorch/pytorch#96741

Pull Request resolved: pytorch/pytorch#96744
Approved by: https://github.com/zou3519
@kshitij12345 kshitij12345 mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We have not yet implemented the batching rule for aten::where.Scalar.
4 participants
@kshitij12345 @pytorchmergebot @zou3519 @pytorchbot