Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c10d] Bridge c10d and gloo stores. #100384

Closed
wants to merge 6 commits into from
Closed

[c10d] Bridge c10d and gloo stores. #100384

wants to merge 6 commits into from

Conversation

kumpera
Copy link
Contributor

@kumpera kumpera commented May 1, 2023 •
edited

@kumpera kumpera mentioned this pull request May 1, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 1, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100384

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 24484e0:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kumpera kumpera mentioned this pull request May 1, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label May 1, 2023
This was referenced May 1, 2023
Closed
Closed
Closed
kumpera pushed a commit that referenced this pull request May 1, 2023
[c10d] Bridge c10d and gloo stores.
00a787f 
ghstack-source-id: 7bca9749f5e07e9693ade38875295c38bea8e88e
Pull Request resolved: #100384
kumpera pushed a commit to kumpera/pytorch that referenced this pull request May 2, 2023
[c10d] Bridge c10d and gloo stores.
3902c7f 
This updates gloo to pick new store API.

ghstack-source-id: 7bca9749f5e07e9693ade38875295c38bea8e88e
Pull Request resolved: pytorch#100384
@kumpera kumpera mentioned this pull request May 4, 2023
Closed
@kumpera kumpera mentioned this pull request May 5, 2023
Closed
This was referenced May 5, 2023
Closed
Closed
fduwjj
fduwjj approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fduwjj
fduwjj approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumpera kumpera added topic: performance topic category topic: not user facing topic category labels May 9, 2023
@kumpera
Copy link
Contributor Author

kumpera commented May 9, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@kumpera
Copy link
Contributor Author

kumpera commented May 9, 2023

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@kumpera
Copy link
Contributor Author

kumpera commented May 11, 2023

@pytorchmergebot merge -f "the bot is saying green tests are failing."

1 similar comment
@kumpera
Copy link
Contributor Author

kumpera commented May 12, 2023

@pytorchmergebot merge -f "the bot is saying green tests are failing."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jeanschmidt
Copy link
Contributor

@pytorchbot revert -m "breaking internal builds" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@kumpera your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request May 15, 2023
@pytorchmergebot
Revert "[c10d] Bridge c10d and gloo stores. (#100384)"
13383f4 
This reverts commit 74b2c04.

Reverted #100384 on behalf of https://github.com/jeanschmidt due to breaking internal builds ([comment](#100384 (comment)))
jcaip pushed a commit that referenced this pull request May 23, 2023
@pytorchmergebot @jcaip
Revert "[c10d] Bridge c10d and gloo stores. (#100384)"
a6095b8 
This reverts commit 74b2c04.

Reverted #100384 on behalf of https://github.com/jeanschmidt due to breaking internal builds ([comment](#100384 (comment)))
@facebook-github-bot facebook-github-bot deleted the gh/kumpera/25/head branch June 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category Reverted topic: not user facing topic category topic: performance topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumpera @pytorchmergebot @jeanschmidt @fduwjj