[C10D] Rewrite TCPStore client send path to minimize amount of syscalls. #100742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. [ghstack-poisoned]
kumpera
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
wanchaol and
fegin
as code owners
pytorch-bot
bot
added
the
release notes: distributed (c10d)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100742
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c75bef3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 5, 2023
kumpera
pushed a commit
that referenced
this pull request
May 5, 2023
Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. ghstack-source-id: bfa1ed9dc274823176647a9c31454ff0f336fa9b Pull Request resolved: #100742
…t of syscalls." Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. [ghstack-poisoned]
fduwjj
approved these changes
May 8, 2023
| public: | ||
| SendBuffer(detail::TCPClient& client, detail::QueryType cmd) | ||
| : client(client) { | ||
| buffer.reserve(32); // enough for most commands |
There was a problem hiding this comment.
Can we make this a const or adjustable rather than hard code it?
added 2 commits
May 9, 2023 14:29
…t of syscalls." Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. [ghstack-poisoned]
…t of syscalls." Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. [ghstack-poisoned]
kumpera
pushed a commit
that referenced
this pull request
May 31, 2023
Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. ghstack-source-id: ecf08e21a7326f398411f0882854b089094c1cfa Pull Request resolved: #100742
kumpera
added
topic: performance
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
alimoezzi
pushed a commit
to alimoezzi/pytorch
that referenced
this pull request
Jun 3, 2023
…ls. (pytorch#100742) Accumulate data in a local buffer prior to sending it. This reduces the number of syscalls and network packets. We flush every 1440 bytes to cap the amount of temporaty memory. Pull Request resolved: pytorch#100742 Approved by: https://github.com/fduwjj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Accumulate data in a local buffer prior to sending it. This reduces
the number of syscalls and network packets.
We flush every 1440 bytes to cap the amount of temporaty memory.