bsr_dense_mm(): better test coverage #100543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100543
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ddb3f0a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nikitaved
added a commit
that referenced
this pull request
May 3, 2023
ghstack-source-id: e31a77f85f1baaf0fdcd29d8fb71008d98113549 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 4, 2023
ghstack-source-id: 71b3ae9c26eb9e974453458af2ac0489cda374c6 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 4, 2023
ghstack-source-id: 4e95280522b9e60764e0b4b027cb89b5a1f026ca Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 4, 2023
ghstack-source-id: a804f5d01e00004abb496994875b8e53a7488c77 Pull Request resolved: #100543
cpuhrsch
approved these changes
May 4, 2023
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 4, 2023
ghstack-source-id: 54817c0eea5ff707ba16c815f3e5485dc3101fbc Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 4, 2023
ghstack-source-id: f97f73bb21400ecbc695ffe5782e2b28f5d20c5b Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 5, 2023
ghstack-source-id: 0d110e6cb320aec10dc7a5b4d73a791ab974bbc3 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 5, 2023
ghstack-source-id: 8abe3a852d82a521fdb1c7d4fe8e3d3faca03689 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 8, 2023
ghstack-source-id: 0debfbc26b7f1f01ff936b0eacdaf5cb13e81b43 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 8, 2023
ghstack-source-id: 2bcd8a6281a1ace6da686838d081e5dea6e1a980 Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
nikitaved
added a commit
that referenced
this pull request
May 8, 2023
ghstack-source-id: 2294634372f8b2c8b453bbfbffbbed8f7a483b2f Pull Request resolved: #100543
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - enabling correctness tests for `float32` - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - ~~enabling correctness tests for `float32`~~. - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
malfet
approved these changes
May 8, 2023
Comment on lines
+3415
to
+3417
| if torch.cuda.device_count() > 1: | ||
| with self.assertRaisesRegex(ValueError, "on the same GPU device"): | ||
| bsr_dense_mm(lhs.to("cuda:0"), rhs.to("cuda:1")) |
There was a problem hiding this comment.
We should keep all mutli-GPU tests separate (and decorated with @requiresMultiGPU or something like that)
malfet
reviewed
May 8, 2023
| check( | ||
| not n % row_block, | ||
| f"bsr_dense_mm(): dense.size(-1) == {n} should be divisible by " | ||
| f"blocksize[0] == {row_block}.", | ||
| ) | ||
|
|
||
| def is_power_of_two(v): | ||
| return not (v & (v - 1)) |
There was a problem hiding this comment.
Nit (I'm not sure how not is defined for integers in Python, perhaps you can send a link
Suggested change
| return not (v & (v - 1)) | |
| return v & (v - 1) == 0 |
There was a problem hiding this comment.
From https://docs.python.org/3/reference/expressions.html#not:
"In the context of Boolean operations, and also when expressions are used by control flow statements, the following values are interpreted as false: False, None, numeric zero of all types, and empty strings and containers (including strings, tuples, lists, dictionaries, sets and frozensets). All other values are interpreted as true. User-defined objects can customize their truth value by providing a bool() method."
There was a problem hiding this comment.
My point here, is that, in my mind, mixing logical and and boolean not hurts readability, on the other hand, it's up to an author/maintainer of the codebase. I.e. as long as @cpuhrsch is fine reading that, I'm ok as well.
This PR improves test coverage for `bsr_dense_mm` by: - ~~enabling correctness tests for `float32`~~. - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - ~~enabling correctness tests for `float32`~~. - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
This PR improves test coverage for `bsr_dense_mm` by: - ~~enabling correctness tests for `float32`~~. - extending and testing input correctness checks. cc alexsamardzic pearu cpuhrsch amjames bhosmer [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for
bsr_dense_mmby:enabling correctness tests for.float32Stack from ghstack (oldest at bottom):
cc @alexsamardzic @pearu @cpuhrsch @amjames @bhosmer