New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functorch] Skip docs setup if called in optimize mode #100750
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100750
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 05fd424: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Note that we fixed these before by adding None checks before instead of checking the optimize flag: #76619 |
6a9ba3f
to
3cd067a
Compare
@albanD thanks for the feedback. Added it to the test and use |
Test plan: `python3 -OO -c "import torch._functorch.deprecated"`
3cd067a
to
05fd424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
@pytorchbot merge |
Merge failedReason: This PR needs a label If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Test plan:
python3 -OO -c "import torch._functorch.deprecated"
Fixes #100680
cc @zou3519 @Chillee @samdow @soumith @kshitij12345 @janeyx99