-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed direct doc formatting #76619
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d205f79 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakagespull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)Step: "Test" (full log | diagnosis details | 🔁 rerun)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in distributed/rpc
folder LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
I would be curious to know if there is a significant perf hit with leaving these? |
@pytorchbot merge this please |
Hey @vitrioil. |
Summary: Fixes #76034 This does not make python remove all `__doc__` because in some places `__doc__` is assigned to a string. Example: https://github.com/pytorch/pytorch/blob/04b3313379712098183dfe5bea002a5e43b5af48/torch/nn/modules/conv.py#L174-L233 Since there are quite a few of these, I will add all of them together in this PR later. (Basically still a lot of docstring will persist even with `-OO` enabled.) Pull Request resolved: #76619 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f92cddd89030af9389f20d7c75c0831efbf9a2ba Reviewed By: malfet Differential Revision: D36073490 fbshipit-source-id: 49efc08a09facefa705fc25d1ad2bd368d86ca28
Fixes #76034
This does not make python remove all
__doc__
because in some places__doc__
is assigned to a string.Example:
pytorch/torch/nn/modules/conv.py
Lines 174 to 233 in 04b3313
Since there are quite a few of these, I will add all of them together in this PR later. (Basically still a lot of docstring will persist even with
-OO
enabled.)