Restore Vulkan tests to periodic #101026
Closed
Restore Vulkan tests to periodic #101026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
added
ciflow/periodic
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/101026
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f55c490: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
May 11, 2023
|
@pytorchbot merge -f 'All tests have passed, no need to run trunk' |
huydhn
added a commit
to pytorch/test-infra
that referenced
this pull request
May 11, 2023
This goes together with pytorch/pytorch#101026
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flaky issue has been fixed by #100909. In addition, retry support for C++ is now available after #99956. So it's safe to move this back from unstable now.
Per the discussion with @clee2000, it makes sense to have this as a periodic job given that this one rarely fails. To prevent any gap here, I have created pytorch/test-infra#4144 to add the necessary testing for Vulkan change.