Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 9, 2023

This goes together with pytorch/pytorch#101026

@huydhn huydhn requested review from a team and clee2000 May 9, 2023 23:14
@vercel
Copy link

vercel bot commented May 9, 2023

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2023
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 11:18pm

@huydhn huydhn merged commit 69ef709 into pytorch:main May 11, 2023
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request May 11, 2023
The flaky issue has been fixed by #100909.  In addition, retry support for C++ is now available after #99956.  So it's safe to move this back from unstable now.

Per the discussion with @clee2000, it makes sense to have this as a periodic job given that this one rarely fails.  To prevent any gap here, I have created pytorch/test-infra#4144 to add the necessary testing for Vulkan change.

Pull Request resolved: #101026
Approved by: https://github.com/kit1980
@malfet
Copy link
Contributor

malfet commented May 16, 2023

We had issue at some point to consolidate autolabel logic from pytorchbot with that in https://github.com/pytorch/pytorch/blob/main/.github/labeler.yml

@huydhn
Copy link
Contributor Author

huydhn commented May 16, 2023

We had issue at some point to consolidate autolabel logic from pytorchbot with that in https://github.com/pytorch/pytorch/blob/main/.github/labeler.yml

Noted. I'm curious to see if labeler action supports the same use case here on regex match on title and body.

@huydhn huydhn deleted the vulkan-label branch June 9, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants